search

hotsh / rstat.us

Simple microblogging network based on the ostatus protocol.
http://rstat.us/
Other
722 stars 215 forks source link

Switch to using Thin instead of Unicorn #667

Closed tgraham closed 12 years ago

tgraham commented 12 years ago

Fixes Issue #547

tgraham commented 12 years ago

I guess we'll have to agree to disagree because what might be considered sane for one person might not work for another so great leaps are being taken when assuming a default is sane.

I wouldn't want to classify all users as wanting unicorn and expecting them to deploy to heroku, by default.

wilkie commented 12 years ago

Sane is what works in 90% of cases. Surely, webrick as a default production server is weird, right? And terrible for people who aren't rubyists and want to be able to deploy without having to edit anything.

Valarissa commented 12 years ago

I would agree with thin as a good alternative to Unicorn that should be an effective default. Webrick is simply unusable as a production server.

carols10cents commented 12 years ago

I pretty much merged this as part of merging #665. Thank you @tgraham!!! :star: :heart:

steveklabnik commented 12 years ago

Bikeshed comment for puma here ;)

steveklabnik commented 11 years ago

Given https://blog.heroku.com/archives/2013/2/16/routing_performance_update/ thin is actually significantly worse.

wilkie commented 11 years ago

Worse than Unicorn? Well, yes, with Rails the way it is now that's true. That's why it originally had the comment "Strongly encouraged" :) But, it was part of our needs to run on Windows story, and this is the world we live in. Yanno? Our defaults were encouraged to be 'easy' and 'ubiquitous' with an assumption that nodes will not require severe concurrency and thus Unicorn is not as acceptable of a default. An extra commit was recommended here to switch to Unicorn when those assumptions are wrong, for instance, for a large-scale node such as the main rstat.us instance.

steveklabnik commented 11 years ago

I submitted a PR specifically to discuss the issue further. ;)