carols10cents
commented
11 years ago Hey, I'm so sorry it took us so long to get to this. I'm personally super excited about this fix because I keep hitting this issue when i'm using rstat.us! So thank you!!! :heart: :heart: :heart:
I did make a few little changes, nothing major though:
- I took out some booleans that can be implied - the ternary operator isn't really necessary since the first statement already returns true or false, and then instead of checking for something being equal to false, we can just say !something. :)
- I took out the 'it' in the test description - this is super picky but I'm kind of OCD -- if you read the 'it' that comes before the description as part of the description, then we don't need to put 'it' in the description (and now I'm starting to feel like I'm in a monty python movie).
I've also added you to the About page and made you a committer-- please read the section in the README about what that means and let me know if you have any questions :)
Welcome to the team!!! Thank you for your contribution!! :heart: :heart: :heart:
LennonRubin
This pull request is in regards to issue 654 https://github.com/hotsh/rstat.us/issues/654
I have changed the updates_controller create method to check the request url for the reply parameter and if found, redirects to the homepage instead of keeping the reply paramater in the redirect.
I have also written a test to cover this new redirect logic in update_test.rb