search

hotsh / rstat.us

Simple microblogging network based on the ostatus protocol.
http://rstat.us/
Other
722 stars 215 forks source link

Escaping the autocomplete regexp to fix #666 #672

Closed egrajeda closed 12 years ago

egrajeda commented 12 years ago

This is the test and code that fixes hotsh/rstat.us#666, regarding the sanitization of the autocomplete regexp.

I also deleted an extra .downcase that wasn't needed since the comparison ignores case.

Let me know of any comment you may have.

caleywoods commented 12 years ago

:+1:

wilkie commented 12 years ago

I'm kinda curious as to why the original code pushes a downcase version out to the client. Also, why it isn't an Array#select and map rather than an inject. Either way, this fixes the bug. :)

carols10cents commented 12 years ago

Hey @egrajeda, since this was merged in I've added you to the team of committers! Please read the section in the readme about what being a committer means and let me know if you have any questions :heart::heart: Welcome to the team!

I should also have you up on the About page in a few minutes! I hope to be seeing more contributions from you!!