hotsh / rstat.us

Simple microblogging network based on the ostatus protocol.
http://rstat.us/
Other
722 stars 215 forks source link

add .bundle to .gitignore #677

Closed lest closed 12 years ago

steveklabnik commented 12 years ago

:+1:

zph commented 12 years ago

Misclicked on android github app :p. But I'll check it when home and merge.

steveklabnik commented 12 years ago

Hm. Is this actually necessary? Why don't we have a .bundle directory in the current checkin?

zph commented 12 years ago

Leaving this one for someone more familiar the project. :smile:

lest commented 12 years ago

From the bundler documentation:

Before deploying an app that uses Bundler, Add your Gemfile and Gemfile.lock to source control, but ignore the .bundle folder, which is specific to each machine.

steveklabnik commented 12 years ago

Right, I'm not denying that it's a good idea, I'm just curious if it's some sort of default these days. And why, if this hasn't been in our .gitignore, we don't have one in source control already

jrgifford commented 12 years ago

I know I have mine in my global gitignore.

wilkie commented 12 years ago

Tsk Tsk. Yet another application stuffing things in the project directory instead of somewhere else outside of the repo so that they have to depend on the ignore semantics of your-favorite-source-control. And of course, you cannot depend on anybody have a sane global .gitignore (.hgignore, etc) either.

Freaking bad manner I tells ya!

Now, I believe the default for bundler is currently ~/.bundle and rvm especially sets GEM_HOME so that they are installed in isolation as a gemset. Therefore, we will never see a .bundle directory... and I've never seen one in any project directory. When can this occur such that this would be a problem?

lest commented 12 years ago

@wilkie I used to run bundle install --path to install gems from different projects to the different locations. So it creates .bundle/config yaml file with config including gem path.

steveklabnik commented 12 years ago

Yet another application stuffing things in the project directory instead of somewhere else outside of the repo so that they have to depend on the ignore semantics of your-favorite-source-control.

This is because it's important for things like, say, deployment.

Anyway, global .gitignore makes sense. Good enough reason for me. Merged. Thanks.