search

hotsh / rstat.us

Simple microblogging network based on the ostatus protocol.
http://rstat.us/
Other
722 stars 215 forks source link

Empty search of updates doesn't work #702

Closed carols10cents closed 11 years ago

carols10cents commented 11 years ago

Since we started using tire/ElasticSearch, doing an empty search to get all updates stopped working.

The behavior is deceiving because if you go to https://rstat.us/search it says "no statuses match your search", but if you submit the search form you get sent to https://rstat.us/search?search= which currently throws an error.

I'm seeing logs of the google bot going directly to URLs like https://rstat.us/search?page=742&per_page=20&search= which is now throwing an error.

We should probably just fall back to paginating through all Updates and not even bothering tire at all if params[:search] is blank.

bglusman commented 11 years ago

I'll see if I can knock this out quickly... crap, maybe not so quick, issues building eventmachine may stop me from testing this unless I fix quickly

bglusman commented 11 years ago

Oh, I tested this locally, but I didn't write a new acceptance test for it, didn't think of it.. if that's a big deal before merge lmk and I'll try and knock one out and add it in.

carols10cents commented 11 years ago

:heart: :heart: :heart: thank you @bglusman!!!