Shouldn't be able to access /follow or submit the form if you're logged out

hotsh / rstat.us

Simple microblogging network based on the ostatus protocol.

http://rstat.us/

Other

722 stars 215 forks source link

Shouldn't be able to access /follow or submit the form if you're logged out #713

Closed carols10cents closed 11 years ago

carols10cents commented 11 years ago

/follow is the page with the form where you can follow a user on another site; it doesn't make any sense to be allowed to go there if you're not logged in, but you can currently.

Submitting the form with a valid user to follow gives the error:

NoMethodError in SubscriptionsController#create
undefined method `following_feed?' for nil:NilClass

but that action should also be restricted to logged-in users, so someone not logged in shouldn't be able to reach this error message.

usmanbashir commented 11 years ago

I have tried submitting the form my self on a local copy and I'm not being able to reproduce the "NoMethodError".

Can you provide more information that can help in reproducing it?

Though I did encounter a "DoubleRenderError" which I have fixed along with main issue and the pull request is on the way.

usmanbashir commented 11 years ago

This https://github.com/hotsh/rstat.us/pull/714 should fix it.