search

hotsh / rstat.us

Simple microblogging network based on the ostatus protocol.
http://rstat.us/
Other
724 stars 215 forks source link

Several users with invalid usernames #766

Open colindean opened 11 years ago

colindean commented 11 years ago

Linked via https://rstat.us/users:

Side note: All are presumably spam accounts.

wilkie commented 11 years ago

These robots are smart. How did they do that. The error comes from the server, so it's not like you can craft a POST in some obvious way.

This User model validation should not allow this to happen: https://github.com/hotsh/rstat.us/blob/master/app/models/user.rb#L422-L426

How about some optimism. They may left over from when these types of accounts slipped through. It may be time to just delete them or truncate their names to remove the domains.

colindean commented 11 years ago

:hammer: delete!

wilkie commented 11 years ago

Yeah, it is just a bunch of Author classes marked as local with no User. Those can safely be deleted and I have done so.

This is the cause... it shouldn't create an Author if the User model can't be saved: https://github.com/hotsh/rstat.us/blob/master/app/controllers/users_controller.rb#L93

Who wants to fix it? :)