search

hotsh / rstat.us

Simple microblogging network based on the ostatus protocol.
http://rstat.us/
Other
722 stars 215 forks source link

Allows open-uri redirections between HTTP and HTTPS. #803

Closed fmendez closed 10 years ago

fmendez commented 10 years ago

A bit of context on the issue: http://bugs.ruby-lang.org/issues/859

Fixes #741

colindean commented 10 years ago

The build failed on Travis because the therubyracer was added to the Gemfile without being added to the Gemfile.lock. This appears to be unrelated to your change, @fmendez.

fmendez commented 10 years ago

@colindean Thanks for the heads up!

Seems to be related to this line on the Gemfile when I bundled up the gem I just added

  # Many Linux environments do not have a javascript environment which is
  # required by the asset generators. However, windows and os x have one
  # provided by the system.
  gem "therubyracer",           "~> 0.11.3" unless RUBY_PLATFORM.match(/darwin|mswin/)

This line will not be executed since it will match darwin (OSX), not sure how to proceed. :' (

colindean commented 10 years ago

It appears to be more of a Travis error. I think we need to do a better job of detecting when to install a JavaScript engine, because what we have there seems no longer appropriate.

No action required on your part, IMO.