search

hotsh / rstat.us

Simple microblogging network based on the ostatus protocol.
http://rstat.us/
Other
724 stars 215 forks source link

Set up puma as heroku intended #820

Closed carols10cents closed 9 years ago

carols10cents commented 9 years ago

According to https://devcenter.heroku.com/articles/deploying-rails-applications-with-the-puma-web-serveSet

um hi so, heh, funny story... we aren't actually using puma by default in production on heroku, ooops

colindean commented 9 years ago

lgtm. travis failure seems unrelated:

  1) Error:
test_0001_follows users on other sites(following remote users::success):
Capybara::ElementNotFound: Unable to find css "#flash"
    /home/travis/build/hotsh/rstat.us/vendor/bundle/ruby/2.1.0/gems/capybara-2.0.3/lib/capybara/result.rb:22:in `find!'
    /home/travis/build/hotsh/rstat.us/vendor/bundle/ruby/2.1.0/gems/capybara-2.0.3/lib/capybara/node/finders.rb:26:in `block in find'
    /home/travis/build/hotsh/rstat.us/vendor/bundle/ruby/2.1.0/gems/capybara-2.0.3/lib/capybara/node/base.rb:78:in `synchronize'
    /home/travis/build/hotsh/rstat.us/vendor/bundle/ruby/2.1.0/gems/capybara-2.0.3/lib/capybara/node/finders.rb:26:in `find'
    /home/travis/build/hotsh/rstat.us/vendor/bundle/ruby/2.1.0/gems/capybara-2.0.3/lib/capybara/session.rb:341:in `block (2 levels) in <class:Session>'
    /home/travis/build/hotsh/rstat.us/vendor/bundle/ruby/2.1.0/gems/capybara-2.0.3/lib/capybara/session.rb:211:in `within'
    /home/travis/build/hotsh/rstat.us/vendor/bundle/ruby/2.1.0/gems/capybara-2.0.3/lib/capybara/dsl.rb:51:in `block (2 levels) in <module:DSL>'
    /home/travis/build/hotsh/rstat.us/test/acceptance/following_remote_users_test.rb:26:in `block (3 levels) in <top (required)>'
colindean commented 9 years ago

fixed link from Carol's PR summary:

https://devcenter.heroku.com/articles/deploying-rails-applications-with-the-puma-web-server

wilkie commented 9 years ago

I noticed we weren't using the proper server. heh. This will help, although, again, how much it helps a single account / single dyno case is not really known to me. But better than the fallback it would currently be subject to.