search

hotwax / facilities

App to manage facilities
Apache License 2.0
1 stars 17 forks source link

Fixed: infinite scroll issue when used with searchbar(dxp-289) #240

Closed R-Sourabh closed 6 months ago

R-Sourabh commented 6 months ago

Related Issues

https://github.com/hotwax/dxp-components/issues/289

Short Description and Why It's Useful

Removed the logic to re-render the infinite-scroll on queryString check that has been added in the previous PR.

Added a variable to check whether the scrolling can be enabled or not whenever users lands on the list page. For this, we have determined the height of the content part scroll and infiniteScroll component and if the height is less than 0 then only enabling the infinite-scroll component

Removed disabled as once the infiniteScroll is disabled it does not gets enabled again, hence removed the disabled property and instead used v-show to enable/disable infinite scroll.

Screenshots of Visual Changes before/after (If There Are Any)

Contribution and Currently Important Rules Acceptance

R-Sourabh commented 6 months ago

We need to handle the same for the parking page as well.

No issue in scrolling on parking page.

Adameddy26 commented 6 months ago

Verified and working fine release v1.6.1. https://jam.dev/c/7ce45f60-d381-416c-8f6b-125161e1dd90