hotwax / facilities

App to manage facilities
Apache License 2.0
1 stars 8 forks source link

Inaccurate removal and update of facility latitude/longitude #255

Open Adameddy26 opened 4 months ago

Adameddy26 commented 4 months ago

Cases

Case 1 - Removal Inconsistency When a user attempts to remove a generated latitude/longitude by clearing the input fields, a toast message displays success, but the values persist. This only occurs for generated coordinates; manually entered values can be removed successfully.

Case 2 - Zero Input Handling Entering "0" (zero) in both latitude and longitude fields and saving doesn't update the facility details page. However, reopening the edit modal and saving again with "0" in both fields allows the update. This behavior needs correction for a consistent user experience.

Case 3 - Editing Restriction Users cannot edit existing latitude/longitude values by typing and saving changes within the input fields. This results in an error message.

Expected Behavior

Case 1: Users should be able to remove previously generated latitude/longitude coordinates by clearing the input fields and saving. The toast message should accurately reflect this action. Case 2&3: The system should prevent saving invalid coordinates like "0" or any other character(except '.' and '-') for both latitude and longitude. Ideally, an error message should prompt the user in this case.

Steps to Reproduce

Login the app with valid user credentials. On the find facilities page, open the facility details of any facility.

Case 1. Unable to Remove Generated Latitude/Longitude

Case 2. Handling '0' Inputs in Latitude/Longitude Fields

Case 3. Error When Editing Field Values

Environment details

App environment : UAT App version : v1.7.0

Additional information

https://jam.dev/c/66947943-b96d-46a0-bbce-c3f0a285b42a

Adameddy26 commented 4 months ago

@R-Sourabh Few more points needs to be considered while fixing this issue -

Case A When latitude/longitude are not generated and user clicks on 'Add' button 1.1. Generate button should appear enabled and If the latitude/longitude is generated successfully, it should get disabled. 1.2. If unable to find the latitude/longitude for types Zip code, generate button should appear enabled. If latitude/longitude are generated successfully and saved. 1.3 On opening the edit modal, generate button should appear disabled until any changes are made to the Zip code field. 1.4 On entering the same value for which latitude/longitude were generated previously, the button should again get disabled. On removing the latitude/longitude and opening the modal again 1.5 Behavior should be same as mentioned for 'When latitude/longitude are not generated and user clicks on 'Add' button'.

Case B User should not be allowed to enter any special character except (-) or 0 inside the Zip code field.

Case C Manual inputs provided to both the fields are not getting saved.

Case D Generate button can be changed to re-generate once the latitude/longitude are saved.

Case E Regenerate option can be removed from the popover options and remove option can be given directly on the card itself.