search

hotwax / fulfillment

HotWax Commerce Fulfillment app
Apache License 2.0
8 stars 37 forks source link

Continuous Loading on UI When Selecting Facility Not Linked with Product Store #709

Open Adameddy26 opened 2 months ago

Adameddy26 commented 2 months ago

Current behavior

Continuous Loading: The UI enters a state of continuous loading and does not complete the action or provide any feedback. Lack of Error Handling: There is no clear error message or indication of the issue to the user.

Expected behavior

Facility Selection: User should not be allowed to select such facility. UI Response: The UI should either display an appropriate error message or notification indicating that the facility is not linked with the product store, rather than showing continuous loading.

Steps to reproduce the issue

Ensure that the facility is not linked with the product store. Navigate to the fulfillment app. Attempt to select the unlinked facility from the settings page. Observe the continuous loading behavior on the UI.

Environment details

App version : v2.7.2 App environment : UAT

Additional information

https://jam.dev/c/54838f80-3851-4e1a-8cdd-1ed46e49d99d

dt2patel commented 2 months ago

Why is a facility not linked to the product store even showing in the app?

ymaheshwari1 commented 2 months ago

Why is a facility not linked to the product store even showing in the app?

We fetch productStore based on facility and not vice-versa. We don't have any check of productStore when fetching facilities.

Also here we either fetch all the facilities of the system which are in OMS_FULFILLMENT group if the user is a admin user, otherwise we fetch the facilities associated (in group OMS_FULFULLMENT) with the logged-in user.