search

hotwax / inventory-count

HotWax Commerce Inventory Count
Apache License 2.0
16 stars 66 forks source link

Toast message 'Enter a count before saving changes' is not displayed when saving an empty re-count. #397

Closed Adameddy26 closed 2 months ago

Adameddy26 commented 3 months ago

Note

Suggestion - When the user clicks the re-count button, the previous count should automatically populate in the count field.

Current behavior

The re-count is saved even if the count field is empty, and no toast message is displayed, allowing incomplete data to be saved.

Expected behavior

A toast message saying "Enter a count before saving changes" should appear when the save button is clicked without a count entered. The re-count should not be saved until a valid count is provided.

Steps to reproduce the issue

Open the App store view screens and open any count from the assigned tab. Click on the re-count button in the application. Attempt to save the re-count without any visible data in the count field. Observe the issue.

Environment details

App version : INVENTORY-COUNT-2.0-E488779 App environment : DEV

Additional information

https://jam.dev/c/3a09cdf4-fde2-4d3c-ac8a-5a3d26e27128

Adameddy26 commented 2 months ago

Verified and working fine in release v2.0.0. Hence, closing this issue. https://jam.dev/c/170345ed-b749-4756-ab96-cb69a7b76e69