hotwax / job-manager

HotWax Commerce Job Manager App
https://job-manager.hotwax.io/
Apache License 2.0
13 stars 31 forks source link

UI changes required in custom parameter bottom sheet #678

Closed Adameddy26 closed 2 months ago

Adameddy26 commented 4 months ago

Current behavior

Users are confused about how to apply changes or confirm their selections within the pop-up.

Expected behavior

  1. Close button should not be present in the bottom sheet, the user should click on the backdrop to discard changes.
  2. Save button should be present in the right slot of the header.
  3. Copy functionality should be available for required and optional parameter groups.

Steps to reproduce the issue

Open the Job Manager App. Open any job. Open custom parameter pop-up window.

Environment details

Additional information

Screenshot 2024-02-16 at 12 10 07 PM

ymaheshwari1 commented 4 months ago

@Adameddy26 @Dhiraj1405 I think this modal should have a close button as well, so that user have a direct option to close the modal, instead of him finding a way to the close the modal once opened.

Also in case when a job is in pending state we don't allow user to make any changes in the custom parameters, so having save button will confuse the user about this behaviour.

Dhiraj1405 commented 4 months ago

For the first point, I agree, that we can have a close icon. For the second point, let's disable the save button when the job is in a pending state.

amansinghbais commented 2 months ago

Based on discription with @Dhiraj1405 sir, we have given two individual copy buttons for required and optional parameters respectively. Because of this we have changed the format for the copied object as object of key value pair as parameter and their value.

Adameddy26 commented 1 month ago

Changes verified and working fine in release v2.23.1. Hence, closing this ticket.