hotwax / job-manager

HotWax Commerce Job Manager App
https://job-manager.hotwax.io/
Apache License 2.0
13 stars 31 forks source link

Allow user to login even if shopifyShop association is not present for selected productStore #685

Closed ymaheshwari1 closed 5 months ago

ymaheshwari1 commented 6 months ago

Current behavior

When the selected productStore is not associated with any shopifyShop we do not allow user to login into the app.

Expected behavior

A user should be able to login into the app without having shopifyShop association for the selected productStore.

If the selected productStore is not associated with any shopifyShop, then in such case all those jobs cannot be scheduled for which shopifyShop is required field as service in-param. In this case if the shopifyShop is not selected then the user can only modify those jobs for which shopifyShop is not required, and all the other job options can be disabled.

Steps to reproduce the issue

Can you handle fixing this bug by yourself?

Environment details

Additional information

amansinghbais commented 6 months ago

Based on the discussion with @ravilodhi sir and @ymaheshwari1 sir,

Currently the code we have, checks for the shopifyConfigId on the action for scheduling job and if no shopifyConfig is found we show a toast message telling that shopify configuration is not found. Hence for now we are not disabling the job configuration buttons.

Adameddy26 commented 5 months ago

Enhancement verified and working fine in release v2.22.0. Hence, closing it. https://jam.dev/c/0b153436-2849-484e-b118-36a70c58b609