hotwax / job-manager

HotWax Commerce Job Manager App
https://job-manager.hotwax.io/
Apache License 2.0
13 stars 31 forks source link

Remove extra lines when displaying helper or error text for custom params and hide the copy option from custom params modal when no params are available #698

Closed ymaheshwari1 closed 2 weeks ago

ymaheshwari1 commented 2 months ago

Current behavior

image

Expected behavior

Steps to reproduce the issue

Can you handle fixing this bug by yourself?

Environment details

Additional information

Check for the multiple lines case on all the places where we have used helper/error text.

Adameddy26 commented 2 months ago

Issue verified in release v2.23.0 and found that issue is still there as no line is visible in between the optional custom parameters as seperator. https://jam.dev/c/f962d025-73f8-4ea8-a4b5-610b86da47ab

amansinghbais commented 2 months ago

Fixed the above issue in following PR: https://github.com/hotwax/job-manager/pull/708

Adameddy26 commented 2 weeks ago

Verified and working fine in release v2.23.1. Hence, closing it.