hotwax / launchpad

Apache License 2.0
3 stars 19 forks source link

Incorrect Toast Message Displayed for Blocked/Disabled User Access Attempt #103

Closed Adameddy26 closed 5 days ago

Adameddy26 commented 8 months ago

Expected behavior

The toast message should accurately convey that the user account is blocked or disabled, providing clear information to the user about the reason for denied access.

Steps to reproduce the issue

Block or disable a user account within the application. Attempt to access the application using the blocked or disabled user account credentials. Observe the toast message displayed upon denied access.

Environment details

Additional information

Screenshot 2024-03-12 at 1 00 43 PM

dt2patel commented 7 months ago

This issue should be in Launchpad since that is where all login is handled. Transferring issue.

ymaheshwari1 commented 4 months ago

@dt2patel Sir, Currently we are thinking of updating the message to Sorry, either your login details are incorrect, or your account has been disabled or blocked. Please try again or contact administrator.. As its difficult to identify from the api response that whether the credentials are wrong or account is blocked.

dt2patel commented 4 months ago

Let's work on improving the API response. @ymaheshwari1 we can discuss in person

dt2patel commented 3 months ago

UI for blocked user will be handled in this issue: https://github.com/hotwax/dxp-components/issues/204

ymaheshwari1 commented 5 days ago

Handling of error messages for disabled/blocked user will be handled in https://github.com/hotwax/dxp-components/issues/204, hence closing this issue.