search

hotwax / launchpad

Apache License 2.0
3 stars 19 forks source link

Remove Unnecessary "Please fill details" Toast on Pre-filled Login Page #58

Closed Dhiraj1405 closed 4 months ago

Dhiraj1405 commented 1 year ago

Current behavior

Expected behavior

Currently, when users are redirected to the login page and their credentials are already pre-filled in the input fields, they receive an unnecessary toast notification prompting them to input credentials. This toast is confusing and redundant, as the credentials are already provided.

Steps to reproduce the issue

Can you handle fixing this bug by yourself?

Environment details

Additional information

dt2patel commented 1 year ago

need to check if this is still happening

ymaheshwari1 commented 1 year ago

This issue occurs mainly on the first time when app becomes unauthorized and logouts.

dt2patel commented 9 months ago

@Adameddy26 can you please review this and attach a jam link for what exactly is happening here.

Adameddy26 commented 8 months ago

@dt2patel Issue is replicated at my end multiple times but the toast message is not getting captured in the JAM video. Therefore, mentioning the steps here.

Steps to Replicate -

  1. Log in the launchpad with a user.
  2. Open the login URL in other window.
  3. Here, log in with same user and then logout from the launchpad.
  4. Go back to first window and logout from the launchpad.
  5. Click on Login button in the first window to observe the issue.

@ravilodhi Please connect with me in case of any doubt.

Adameddy26 commented 4 months ago

Checked it and found that it is working fine. May be it got fixed in impact of some other issue fix. Therefore, closing this issue.