search

hotwax / launchpad

Apache License 2.0
3 stars 19 forks source link

Fixed: screen halt on logging by showing a loader until succesfully logged in (#81) #90

Closed amansinghbais closed 1 month ago

amansinghbais commented 7 months ago

Related Issues

Closes #81

Short Description and Why It's Useful

Added loader on login action to show till successful login.

Screenshots of Visual Changes before/after (If There Are Any)

Screenshot from 2024-08-22 16-27-32 Screenshot from 2024-08-22 16-27-49

IMPORTANT NOTICE - Remember to add changelog entry

Contribution and Currently Important Rules Acceptance

dt2patel commented 1 month ago

The loader should instead be inside the button itself. @amansinghbais

dt2patel commented 1 month ago

Don't need to add margin, just slot is enough. Make sure to use data attribute to ensure spinner size is managed correctly https://github.com/hotwax/hotwax-apps-theme/blob/9779d96ff53e06f8b4e6109d7aefeb5ebf46bfac/css/theme.css#L22C1-L24C2