Improve facility display logic on Admin user details page

hotwax / users

This app is for managing all employees of a company

Apache License 2.0

0 stars 7 forks source link

Improve facility display logic on Admin user details page #173

Open Adameddy26 opened 6 months ago

Adameddy26 commented 6 months ago

Description

Currently, on the user details page of an admin user, the message "Added to 0 facilities" is displayed, even though the user has access to all facilities. This inconsistency in the displayed information can lead to confusion and misinterpretation of the user's access privileges. To enhance clarity and accuracy, this enhancement proposes improving the facility display logic to accurately reflect the admin user's access to facilities.

Additional information

https://jam.dev/c/4bd5bc75-bc92-48d2-be92-4544177b8aca

Dhiraj1405 commented 1 month ago

Will add UI here

dt2patel commented 1 week ago

@Adameddy26 can you share if the ability to view all facilities is checked based on a specific permission? Or is it based on security group? I think it's permission, and if so, what is the permission ID that is check.

Adameddy26 commented 1 week ago

@Adameddy26 can you share if the ability to view all facilities is checked based on a specific permission? Or is it based on security group? I think it's permission, and if so, what is the permission ID that is check.

STOREFULFILLMENT_ADMIN - If this permission is given to any group, then each user in that group will be able to perform operations for every facility

ravilodhi commented 1 week ago

@Adameddy26 @dt2patel

What should be the action item here? Should we display the count for all facilities for the admin/super user and disable the modal that opens to manage the user's facilities? If not, what should the behavior of the facilities modal be?

dt2patel commented 1 week ago

Sorry looks like I forgot to attach UI: