Closed blopker closed 3 years ago
Thanks for the review @davish! I'm part of this org now, but still can't merge this PR. Can you add me to this repo? If you make me an admin I can help add people too as needed.
Hmm... I also don't have admin access but I can merge, since I think I asked @C4ptainCrunch to make me a maintainer. @C4ptainCrunch could you add @blopker to the maintainer list so he can merge the PR? I can also merge this one in myself
Ah, too bad! If you could, please go ahead and merge this so we can move forward. It would be good to get admin access for one or both of us for this repo so we can set up things like GitHub actions.
You are now both in the @hotwire-django/maintainers team that should grant you almost every access on turbo-django, stimulus-django and hotwire-django :)
This PR vendors the JS libraries. This is useful so users of this package don't have to rely on third party CDNs which is against many companies' security policies and adds another failure point to sites. If people want to use other versions of the vendored libs or want to create their own JS bundle, it should be easy enough to just not include the
head.html
template and use their own solution.List of changes:
venv
module so we don't rely on thevirtualvenv
package being installed globally.channels
frominstall_requires
so people using WSGI don't need to have it installed. We'll want to mention something about installing it in the Streams install instructions.static
tag withdata-turbo-track="reload"
so the JS files get fingerprinted and Turbo reloads itself when those resources change in production.defer
to script tags so they don't block rendering the rest of the page.localhost
, also now supports secure connections.