hotwire-django / turbo-django

Unmaintained // An early stage integration of Hotwire Turbo with Django
https://discuss.hotwire.dev/t/django-backend-support-for-hotwire/1570/
Other
385 stars 20 forks source link

Vendor JS Libs #10

Closed blopker closed 3 years ago

blopker commented 3 years ago

This PR vendors the JS libraries. This is useful so users of this package don't have to rely on third party CDNs which is against many companies' security policies and adds another failure point to sites. If people want to use other versions of the vendored libs or want to create their own JS bundle, it should be easy enough to just not include the head.html template and use their own solution.

List of changes:

blopker commented 3 years ago

Thanks for the review @davish! I'm part of this org now, but still can't merge this PR. Can you add me to this repo? If you make me an admin I can help add people too as needed.

davish commented 3 years ago

Hmm... I also don't have admin access but I can merge, since I think I asked @C4ptainCrunch to make me a maintainer. @C4ptainCrunch could you add @blopker to the maintainer list so he can merge the PR? I can also merge this one in myself

blopker commented 3 years ago

Ah, too bad! If you could, please go ahead and merge this so we can move forward. It would be good to get admin access for one or both of us for this repo so we can set up things like GitHub actions.

C4ptainCrunch commented 3 years ago

You are now both in the @hotwire-django/maintainers team that should grant you almost every access on turbo-django, stimulus-django and hotwire-django :)