hotwired-laravel / turbo-laravel

This package gives you a set of conventions to make the most out of Hotwire in Laravel.
https://turbo-laravel.com
MIT License
803 stars 50 forks source link

Release preparation #88

Closed tonysm closed 2 years ago

tonysm commented 2 years ago

Just so I don't forget.

Release notes:

Note: The targets change needs to be tested properly. We need to create some queued Turbo Stream broadcasts with the previous package version, let them sleep in the queue as we update the package, then try to process them with the new package version. I think it should be fine, but not sure. If this works fine, we can tag a minor version. Otherwise, we will need a major version bump.

timvdalen commented 2 years ago

Awesome work! One thing to note: the signature for the Stream component did change, so it might be safest to assume someone is using that (since it's part of the public API) and go up a major version.

tonysm commented 2 years ago

@timvdalen yeah but by the way components are used, it's not really a breaking change... I mean, they are only used inside Blade views, so from that point of view, the signature change is really not a breaking change 🤔

timvdalen commented 2 years ago

Yeah I guess it depends on if anyone has used them directly, but I would think not!

tonysm commented 2 years ago

For reference, I've tested out having queued jobs on the previous version of the BroadcastAction job stored and upgrading, one bug happened which was related to the new $targets property not being initialized (since the class was serialized and then unserialized from the queue without any value). Setting the nullable properties to null by default fixed this issue (here), so I think we can move on with the release tagging a minor version.

If anyone has an issue with this, let me know.

tonysm commented 2 years ago

Version 1.6.0 was released. 🎉🎉🎉