search

hotwired / hotwire-native-android

Hotwire Native for Android
MIT License
41 stars 5 forks source link

Call sendDialogResult from onDialogDismiss (Fixes #63) #69

Open harshalbhakta opened 1 week ago

harshalbhakta commented 1 week ago

Fixes #63

onDialogCancel gets called when dialog is dismissed by pulling down. Everything works as expected. Screen does not freeze.

https://github.com/hotwired/hotwire-native-android/blob/218a7f799d4a4a5c721aa7f1aadff598970320d8/navigation-fragments/src/main/java/dev/hotwire/navigation/fragments/HotwireFragmentDelegate.kt#L81-L86

onDialogDismiss gets called when close button is clicked. The screen freezes here.

https://github.com/hotwired/hotwire-native-android/blob/218a7f799d4a4a5c721aa7f1aadff598970320d8/navigation-fragments/src/main/java/dev/hotwire/navigation/fragments/HotwireFragmentDelegate.kt#L91-L93