search

hotwired / stimulus

A modest JavaScript framework for the HTML you already have
https://stimulus.hotwired.dev/
MIT License
12.67k stars 420 forks source link

NPM package for @stimulus/polyfills #60

Closed rrosen closed 6 years ago

rrosen commented 6 years ago

Cool project! Would love to see a package for https://github.com/stimulusjs/stimulus/tree/master/packages/%40stimulus/polyfills on NPM to ease adding IE/Safari support. Thanks!

javan commented 6 years ago

Thank you. We've outlined those polyfills and their source packages in the installation guide and would rather not publish a package that just exports other packages.

mrmartineau commented 6 years ago

@javan the installation guide copy is not clear enough because it reads like you support IE11 without having to have polyfills. I have submitted a PR with a suggestion: https://github.com/stimulusjs/stimulus/pull/135

mrmartineau commented 6 years ago

@javan I also think adding @stimulus/polyfills as an npm package would be really useful

mrmartineau commented 6 years ago

I didn't see that the wheels were already in motion: https://github.com/stimulusjs/stimulus/pull/134 👍

rathboma commented 6 years ago

+1 to adding an actual @stimulus/polyfills package