search

hotwired / turbo-android

Android framework for making Turbo native apps
MIT License
408 stars 51 forks source link

Swipe to refresh and nested scrolling in Turbo web view conflicts #243

Closed annajeanine closed 4 months ago

annajeanine commented 1 year ago

I'm experiencing a scrolling issue with Turbo Android.

The situation is as following: https://user-images.githubusercontent.com/17251777/188081028-0399329e-7be1-4030-b3fd-7a64d7cebe23.mov

When the user wants to scroll up in the modal drop down, the pull to refresh is triggered in the TurboSwipeRefreshLayout. This issue can be resolved with a event listener on the TurboSwipeRefreshLayout if this is enabled when the scrollY == 0. But, the TurboSwipeRefreshLayout cannot be accessed from outside of the package as it's an internal class.

Has anyone else experienced this problem? Is it resolvable without forking the package?

annajeanine commented 1 year ago

Anyone?

annajeanine commented 1 year ago

Any update on this?

KarishmaAlignable commented 1 year ago

I am facing similar issue. Have you found any solution yet.

annajeanine commented 1 year ago

I am facing similar issue. Have you found any solution yet.

No unfortunately not yet!

connorbey13 commented 1 year ago

I found a workaround by adding JS to my modal from here: https://stackoverflow.com/a/71313997. This isn't an issue on turbo-ios. May need to be fixed in Android WebView itself?

jayohms commented 4 months ago

Closing this as duplicate of https://github.com/hotwired/turbo-android/issues/294 since it has reproducible details.