search

hotwired / turbo-android

Android framework for making Turbo native apps
MIT License
408 stars 51 forks source link

Simplify TurboVisitResponse in debug logs #264

Closed adam-h closed 10 months ago

adam-h commented 1 year ago

Not showing the full HTML in the logs, which makes them tricky to read.

From:

options: TurboVisitOptions(action=ADVANCE, snapshotHTML=null, response=TurboVisitResponse(statusCode=200, responseHTML=<!DOCTYPE html>
    <html class='h-full' lang='en'>
    <head>
    <meta charset='UTF-8'>
    ...snip...
    </body>
    </html>
    ))]

To:

options: TurboVisitOptions(action=ADVANCE, snapshotHTML=null, response=TurboVisitResponse<responseCode: 200 responseLength: 30831>)
jayohms commented 10 months ago

@adam-h Thanks for the feedback! I've addressed this in a slightly different way in https://github.com/hotwired/turbo-android/pull/283 so that it's still clear what the responseHTML contains.

adam-h commented 10 months ago

Nice! Thanks :)