search

hotwired / turbo-android

Android framework for making Turbo native apps
MIT License
408 stars 51 forks source link

Set WebView's height to wrap content if its parent is ScrollingView #266

Closed mbarta closed 1 year ago

mbarta commented 1 year ago

The change to support proper nested scrolling of a WebView inside of a BottomSheet introduced in https://github.com/hotwired/turbo-android/pull/261 unfortunately caused some side-effects to other full-height screens in some cases related to scrolling of nested content.

Therefore, this PR restores the default layout parameters of the shared WebView to MatchParent and only if the WebView's parent is ScrollingView, its height is set to WrapContent.