hotwired / turbo-android

Android framework for making Turbo native apps
MIT License
407 stars 51 forks source link

Properly handle navigate back/up from bottom sheet dialog fragments #306

Closed jayohms closed 4 months ago

jayohms commented 4 months ago

To properly handle dismissing bottom sheet dialog fragments, it's necessary to cancel the dialog instance instead of popping the backstack to receive all the desired Fragment callbacks. Previously, calling navigateBack() or navigateUp() would dismiss the bottom sheet, but leave the underlying WebView screen stuck on a screenshot instead of the interactive attached WebView.

Fixes https://github.com/hotwired/turbo-android/issues/197