search

hotwired / turbo-rails

Use Turbo in your Ruby on Rails app
https://turbo.hotwired.dev
MIT License
2.12k stars 328 forks source link

Intermittent CI failure #402

Open MSP-Greg opened 1 year ago

MSP-Greg commented 1 year ago

I'm involved with Puma, and looking at adding the CI from this repo to its CI. I've got it working with a few 'hacks' needed for Puma 6.0.0. But, there are often frequent intermittent failures like:

Failure:
BroadcastsTest#test_passing_extra_parameters_to_channel [/home/runner/work/turbo-rails/test/system/broadcasts_test.rb:35]:
expected to find text "Hello, world!" in ""

So, I backed things up and used Puma 5.6.5, and still had the same problem. Debugged on the response body sent with "Hello, world!" included, and can't find any difference. Below are the three jobs, the intermittent failures happen in all three.

ubuntu-20.04 Ruby 3.1  Rails 6.1
ubuntu-20.04 Ruby 3.1  Rails 7.0
ubuntu-22.04 Ruby head Rails 7.0

Any ideas? TIA.

MSP-Greg commented 1 year ago

Running tests with -v, it's always the first test run from test/system/broadcasts_test.rb.

Not any particular test, but always the first. I've never seen failures with tests after the first. And, it's an intermittent failure, in that there are CI jobs with no failures.

We're seeing this in Puma's CI, as we're testing with turbo-rails (a good 'real world' test). I can also repo locally.