Progress bar does not disappear when clicking link that returns Turbo Stream

hotwired / turbo

The speed of a single-page web application without having to write any JavaScript

https://turbo.hotwired.dev

MIT License

6.63k stars 419 forks source link

Progress bar does not disappear when clicking link that returns Turbo Stream #1153

Open m4theushw opened 7 months ago

m4theushw commented 7 months ago

I have a page containing a link that returns a Turbo Stream targeting body. The problem is that when the link is clicked, the progress bar appears and remains active indefinitely. The progress bar should disappear after the stream is processed. This bug started after upgrading from 7.3.0 to 8.0.0-beta.4. I believe it has to do with https://github.com/hotwired/turbo/pull/1036 because Turbo Streams don't emit turbo:load.

morki commented 7 months ago

After the same update, It also jumps wierdly on redirects and does not animate first progress "jump"

packagethief commented 6 months ago

Likely related, I've noticed that redirected visits won't remove the progress bar either. To reproduce, create a link to a location that will redirect. After visiting the location and following the redirect, the progress bar remains.