search

houke / acf-icon-picker

Creates an icon picker ACF field
100 stars 47 forks source link

Forces you to pick an icon #5

Closed JiveDig closed 6 years ago

JiveDig commented 6 years ago

No way to close the modal after it pops up. Kind of confusing for the user, and sometimes may not need an icon.

Otherwise this a nice little field type!

JiveDig commented 6 years ago

Just noticed the "Remove" button. That helps, but still would be nice to have a close button on the modal itself.

klaudiomilankovic commented 6 years ago

Hey, thanks, I will add the button for closing.

On Wed, Feb 14, 2018, 11:14 PM Mike Hemberger notifications@github.com wrote:

Just noticed the "Remove" button. That helps, but still would be nice to have a close button on the modal itself.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/houke/acf-icon-picker/issues/5#issuecomment-365762705, or mute the thread https://github.com/notifications/unsubscribe-auth/AG_EVPHh_6epb1yFoQFFWbP_Pg1YTg2dks5tU1rAgaJpZM4SGBrj .

klaudiomilankovic commented 6 years ago

@JiveDig I've added the close option on the modal itself.

JiveDig commented 6 years ago

Good stuff! Works well. Nice improvement :)