Failing do build on OSX Monterey

[clyra]

Hi,

I'm trying to build keymapper on OSX monterey but is failing. Logs shows two errros:

tmp/keymapper-20240805-37170-mnrerh/src/server/unix/main.cpp:219:61: error: too few arguments to function call, expected 3, have 2
    return g_grabbed_devices.grab(virtual_device_name, false) ? 0 : 1;
           ~~~~~~~~~~~~~~~~~~~~~~                           ^
/tmp/keymapper-20240805-37170-mnrerh/src/server/unix/GrabbedDevices.h:28:8: note: 'grab' declared here
  bool grab(const char* virtual_device_name, bool grab_mice,
       ^
1 error generated.
make[2]: *** [CMakeFiles/keymapperd.dir/src/server/unix/main.cpp.o] Error 1

 82%] Linking CXX executable keymapper
/opt/homebrew/Cellar/cmake/3.30.2/bin/cmake -E cmake_link_script CMakeFiles/keymapper.dir/link.txt --verbose=1
/opt/homebrew/Library/Homebrew/shims/mac/super/clang++ -O3 -DNDEBUG -arch arm64 -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX12.sdk -Wl,-search_paths_first -Wl,-headerpad_max_install_names CMakeFiles/keymapper.dir/src/client/ConfigFile.cpp.o CMakeFiles/keymapper.dir/src/client/Settings.cpp.o CMakeFiles/keymapper.dir/src/client/ServerPort.cpp.o CMakeFiles/keymapper.dir/src/client/ControlPort.cpp.o CMakeFiles/keymapper.dir/src/client/ClientState.cpp.o CMakeFiles/keymapper.dir/src/client/unix/FocusedWindowImpl.cpp.o CMakeFiles/keymapper.dir/src/client/unix/FocusedWindowCarbon.cpp.o CMakeFiles/keymapper.dir/src/client/unix/StringTyperImpl.cpp.o CMakeFiles/keymapper.dir/src/client/unix/StringTyperGeneric.cpp.o CMakeFiles/keymapper.dir/src/client/unix/StringTyperCarbon.cpp.o CMakeFiles/keymapper.dir/src/client/unix/TrayIcon.cpp.o CMakeFiles/keymapper.dir/src/client/unix/main.cpp.o CMakeFiles/keymapper.dir/src/common/Connection.cpp.o CMakeFiles/keymapper.dir/src/common/Host.cpp.o CMakeFiles/keymapper.dir/src/common/output.cpp.o CMakeFiles/keymapper.dir/src/config/ParseConfig.cpp.o CMakeFiles/keymapper.dir/src/config/ParseKeySequence.cpp.o CMakeFiles/keymapper.dir/src/config/get_key_name.cpp.o -o keymapper  -framework Carbon
[ 82%] Built target keymapper
make[1]: *** [CMakeFiles/keymapperd.dir/all] Error 2
make: *** [all] Error 2

Here is the environment:

HOMEBREW_VERSION: 4.3.13
ORIGIN: https://github.com/Homebrew/brew
HEAD: 1e560120a65be3b3c7b8a42083d54f795e1d0ec4
Last commit: 17 hours ago
Core tap JSON: 06 Aug 01:05 UTC
Core cask tap JSON: 06 Aug 01:05 UTC
HOMEBREW_PREFIX: /opt/homebrew
HOMEBREW_CASK_OPTS: []
HOMEBREW_MAKE_JOBS: 8
HOMEBREW_NO_BOOTSNAP: set
Homebrew Ruby: 3.3.4 => /opt/homebrew/Library/Homebrew/vendor/portable-ruby/3.3.4_1/bin/ruby
CPU: octa-core 64-bit arm_firestorm_icestorm
Clang: 14.0.0 build 1400
Git: 2.37.1 => /Applications/Xcode.app/Contents/Developer/usr/bin/git
Curl: 8.7.1 => /usr/bin/curl
macOS: 12.7.6-arm64
CLT: 14.2.0.0.1.1668646533
Xcode: 14.2
Rosetta 2: false

HOMEBREW_CC: clang
HOMEBREW_CXX: clang++
MAKEFLAGS: -j8
CMAKE_PREFIX_PATH: /opt/homebrew
CMAKE_INCLUDE_PATH: /Library/Developer/CommandLineTools/SDKs/MacOSX12.sdk/System/Library/Frameworks/OpenGL.framework/Versions/Current/Headers
CMAKE_LIBRARY_PATH: /Library/Developer/CommandLineTools/SDKs/MacOSX12.sdk/System/Library/Frameworks/OpenGL.framework/Versions/Current/Libraries
PKG_CONFIG_LIBDIR: /usr/lib/pkgconfig:/opt/homebrew/Library/Homebrew/os/mac/pkgconfig/12
HOMEBREW_GIT: git
HOMEBREW_SDKROOT: /Library/Developer/CommandLineTools/SDKs/MacOSX12.sdk
ACLOCAL_PATH: /opt/homebrew/share/aclocal
PATH: /opt/homebrew/Library/Homebrew/shims/mac/super:/opt/homebrew/opt/cmake/bin:/usr/bin:/bin:/usr/sbin:/sbin

Obs: i do have karabiner-elements 14.13.0 installed.

[clyra]

The issue seems to be introduced in version 4.5.0. I was able to build version 4.4.5 without issues, but not version 4.5.0.

[houmain]

Thanks for reporting! This should be fixed with the last keymapper commit.

[clyra]

Hi, thanks! just built it.