search

houmain / keymapper

A cross-platform context-aware key remapper.
GNU General Public License v3.0
257 stars 21 forks source link

unique device names #42

Closed G-M0N3Y-2503 closed 1 year ago

G-M0N3Y-2503 commented 1 year ago

I hacked this together quickly so that I could choose devices with the same name other than the first. Not sure how to do it properly but figured this might help.

G-M0N3Y-2503 commented 1 year ago

After some thought, maybe it should use all devices matching the filter

houmain commented 1 year ago

Looks good, thanks. But maybe it would be better to support selecting devices by their vendor/product id? I have my doubts because of the enumeration order and that detaching a device can change the name of other devices...

After some thought, maybe it should use all devices matching the filter

Additionally to that? I will create a ticket.

G-M0N3Y-2503 commented 1 year ago

While testing thease changes today I noticed that mouse mappings wern't working i.e. ButtonBack >> LaunchApp1.
So for my device, which is 1 physical device with 3 event devices. it is more intuitive to treat all thease non-unique device names as the one device.
I suppose this may become an issue if someone wants multiple of the same device with different macros, but I think we should leave this until then.

I'll create an PR that combines multiple devices into one.