search

houndci / hound

Automated code review for GitHub pull requests.
https://houndci.com
MIT License
1.95k stars 401 forks source link

Python: Conflicts vs. the new flake8 #1669

Open cclauss opened 5 years ago

cclauss commented 5 years ago

See: https://github.com/home-assistant/home-assistant/pulls/cclauss

flake8==3.7.5 now check for undefined names (F821) in the type hints in comments. Hound is using flake8==3.6.0 so it disagrees with the current flake8 and raises 'typing.List' imported but unused errors on fixes.

gylaz commented 5 years ago

@cclauss Any idea if 3.7.4 is backwards compatible? Would there any breakage if we upgrade the default to 3.7.4 vs providing 3.7.4 as an opt-in upgrade?

cclauss commented 5 years ago

https://github.com/PyCQA/flake8/tree/master/docs/source/release-notes 3.7.0 upgraded pyfakes and pycodestyle so it is unclear to me.

Opt-in upgrade sounds like the best bet. Perhaps a version number in .hound.yml

flake8:
  enabled: true
  flake8_version: 3.7.4
cclauss commented 5 years ago

flake8_version: 3.7.4 --> 3.7.5 http://flake8.pycqa.org/en/latest/release-notes/index.html