houndci / hound

Automated code review for GitHub pull requests.
https://houndci.com
MIT License
1.95k stars 403 forks source link

Hound passes without violations when using @typescript-eslint/parser #1818

Open robertmaloney opened 4 years ago

robertmaloney commented 4 years ago

In our repo we have .hound.yml configured to run ESLint:

fail_on_violations: true

ruby:
  config_file: .rubocop.yml
  version: 0.63.0

javascript:
  enabled: false

eslint:
  config_file: .eslintrc.json
  version: 6.3.0
  enabled: true

scss:
  config_file: .scss-lint.yml

Additionally we have .eslintrc.json configured to parse using @typescript-eslint/parser, as well as the plugins necessary to check against typescript rules within ESLint. The observed behavior is that, when using that parser, HoundCI passes even with a small set of violations normally caught locally. This issue is resolved when switching to using the babel-eslint parser. Eventually we'd like to use the TS-ESlint parser for its formal support of type-based rules and the long-term EOL of TSLint.

Dependencies:

eslint@6.3.0
@typescript-eslint/parser@2.13.0
@typescript-eslint/eslint-plugin@2.13.0

Subset of ESLint rules tested with (just as an example):

object-curly-spacing
quote-props
array-bracket-spacing
comma-dangle
brace-style
space-before-blocks
yidingww commented 3 years ago

Is this issue fixed? i am still experiencing the same issue using @typescript-eslint/parser with eslint v7.7.0