search

houndci / hound

Automated code review for GitHub pull requests.
https://houndci.com
MIT License
1.95k stars 401 forks source link

Have Hound comment on poorly formatted commit messages #394

Closed linduxed closed 9 years ago

linduxed commented 10 years ago

Tim Pope has a guide for how to write proper commit messages which is by many projects considered to be the required way to write commit messages. thoughtbot's style guide includes a link to this article as well.

While I haven't dug deeply into whether this is easily achieved with the current code of hound, I think it would be good if hound could comment inside offending commits, encouraging better commit messages.

georgebrock commented 10 years ago

I don't think I'd like hound to comment on commit messages: our normal git workflow involves squashing a feature branch into a single commit after it's been reviewed, which means that for thoughtbot repos none of the commit messages that Hound commented on would usually end up living longer than the PR.

Since hound's defaults aim to follow the thoughtbot style guide, if this feature is added I'd at least like it to be off by default.

(Tangentially related: https://github.com/thoughtbot/dotfiles/blob/master/gitmessage and https://github.com/thoughtbot/dotfiles/blob/master/gitconfig#L28-L29)

Koronen commented 10 years ago

As @georgebrock points out, this feature will probably not be useful for all workflows and should likely be turned off by default. I still like this idea though and think it would make sense to prototype it to explore the possibilities.