house-of-abbey / GarminHomeAssistant

Garmin application to provide a dashboard to control your Home Assistant
https://community.home-assistant.io/t/home-assistant-app-for-garmin/637348
MIT License
70 stars 12 forks source link

Allow turning off vibration #118

Closed WebSpider closed 5 months ago

WebSpider commented 5 months ago

Is your feature request related to a problem? Please describe. When making this app available to my partner, she didn't like the vibration caused by executing actions.

Describe the solution you'd like Add an ability to disable vibrations, either in the app's IQ store configuration or in the dashboard definition

Describe alternatives you've considered Turn off the vibration globally in the watch, this is not desireable to my partner

Additional context ~~

philipabbey commented 5 months ago

Include: Fix a dereferencing null bug in HomeAssistantService.mc

Amend this:

var entity_id = data.get("entity_id");
if (entity_id == null) {
    entity_id = "";
}

To this:

var entity_id = "";
if (data != null) {
    entity_id = data.get("entity_id");
    if (entity_id == null) {
        entity_id = "";
    }
}
WebSpider commented 5 months ago

Wow, thanks for the quick followup! :partying_face:

philipabbey commented 5 months ago

This request was quite easy! We're not quite there yet with releasing the new version, might be after the weekend with all the code housekeeping.