search

house-of-abbey / GarminHomeAssistant

Garmin application to provide a dashboard to control your Home Assistant
https://community.home-assistant.io/t/home-assistant-app-for-garmin/637348
MIT License
70 stars 12 forks source link

[Widget] Auto start doesn't work when menu is cached #134

Closed tomasjiricek closed 4 months ago

tomasjiricek commented 4 months ago

Describe the bug When I enable the automatic start after launching (no waiting for tap), it doesn't work when the menu is cached (enabled caching of menu in settings).

IMPORTANT! I have:

To Reproduce Steps to reproduce the behavior:

  1. Go to Connect IQ widget settings
  2. Enable caching of menu and automatic start without waiting for tap
  3. On the watch, if not cached:
    • open the widget
    • let the app load entities/items
    • close the widget, exit it completely
  4. Open the widget
  5. See the widget showing "API" and "Menu" (cached)
  6. See error (not proceeding to menu)

Expected behavior Starting the widget with enabled "automatically start without waiting for tap", it should proceed to menu, instead of waiting for tap.

Screenshots If applicable, add screenshots to help explain your problem.

Garmin Device (please complete the following information):

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

philipabbey commented 4 months ago

I'll mark this as a bug when I have decided it is so!

In the mean time, as we know that auto start does work on other devices, I need to check that you have installed the correct application as there are two. The application at https://github.com/house-of-abbey/GarminHomeAssistant does not support Widgets or autostart, the Widget at https://github.com/house-of-abbey/GarminHomeAssistantWidget does. I need to be sure you have installed the latter before this is a bug.

Thank you for reporting this, I will try and find some time later in the week to follow your instructions to reproduce using the simulator. Presently I am between desktop PCs and without the means to run up the code.

philipabbey commented 4 months ago

There is definitely a bug here.

The menu view is being pushed before the root view which then covers the menu. So the bug (on the simulator) is not quite as you described, but there is definitely one present with the options you have set.

Someone0nEarth commented 4 months ago

There is definitely a bug here.

In the app or in the widget version? @philipabbey

philipabbey commented 4 months ago

In the app or in the widget version?

Only the widget version as the app does not have a root view. Shouldn't be too hard to fix.

Someone0nEarth commented 4 months ago

In the app or in the widget version?

Only the widget version as the app does not have a root view. Shouldn't be too hard to fix.

True. Will have a look on this. Also creating an issue for the widget repo.

philipabbey commented 4 months ago

This issue has been transferred to the correct repo and is now fixed.