search

houseabsolute / DateTime-Format-ISO8601

Parses ISO8601 formats
http://metacpan.org/release/DateTime-Format-ISO8601/
Other
3 stars 3 forks source link

Add parsing for YYYY-MM-DDThh:mm+HH:MM #13

Closed lbjw closed 3 years ago

lbjw commented 3 years ago

Add parsing for YYYY-MM-DDThh:mm+HH:MM (no seconds) which appears to be a valid date according to ISO8601 and has appeared in some dates created by some Java stack.

autarch commented 3 years ago

Thanks for this!

Don't worry about the CI failures. That's an issue with my tooling.

However, this change needs tests too. Also, can you point me towards the part of the ISO 8601 spec that documents this format?

lbjw commented 3 years ago

I don't have a copy of the ISO 8601 standard but various references to ISO 8601 intimate that this is a valid format. By way of example:

"... The formats are as follows. Exactly the components shown here must be present, with exactly this punctuation. Note that the "T" appears literally in the string, to indicate the beginning of the time element, as specified in ISO 8601.

...

Complete date plus hours and minutes: YYYY-MM-DDThh:mmTZD (eg 1997-07-16T19:20+01:00) ... "

Reference: https://www.w3.org/TR/NOTE-datetime

autarch commented 3 years ago

Thanks again. I merged this from the CLI and release it as v0.16.