- Added test for self alias.

houseabsolute / DateTime-Locale

Localization support for DateTime.pm

https://metacpan.org/release/DateTime-Locale/

Other

3 stars 12 forks source link

- Added test for self alias. #7

Closed manwar closed 8 years ago

manwar commented 8 years ago

Hi,

Please review the PR.

Many Thanks. Best Regards, Mohammad S Anwar

autarch commented 8 years ago

The code looks fine. I've started on a style guide for all repos in this org at https://github.com/houseabsolute/houseabsolute-style-guide

The particular issue with this PR is the commit message's use of needless punctuation. Please remove that and amend the existing commit. Then I will merge it. Thanks!

manwar commented 8 years ago

Commit message amended as requested.

autarch commented 8 years ago

Can you rebase so this is just a single commit?

manwar commented 8 years ago

rebased it, please review it now. not sure if I did it correctly. first time ever did rebase. I always do merge.

manwar commented 8 years ago

This PR can be closed without merge.