Get --old timezones into a usable and testable state

[alfiedotwtf]

Hey,

Timezones like 'Etc/GMT+5' end up creating modules like 'DateTime/TimeZone/Etc/GMT+5.pm'. The problem here is that they are not valid Perl module names, so they can't be use'd. These changes fixes this, creates correct offsets, and allows "parse_olson --old" to pass all tests again.

[autarch]

Sorry for the ridiculously slow response. If you could redo this branch without checking in the generated files that'd be good. It's really hard to review as-is.

[alfiedotwtf]

Oops. Missed this one in my inbox. I'll try to do this sometime this week.

[alfiedotwtf]

Let me know if you want anything changed :)

[autarch]

I don't really like the way you have the zone class files names. Having both Etc::GMT_4 and Etc::GMT__4 seems really confusing. Maybe call them Etc::GMT_M4 and Etc::GMT_P4, although the "minus" vs "plus" thing is totally backwards with these zones. I'd welcome a better suggestion, but I think distinguishing the two based on the number of underscores is not a great solution.

Thanks,

-dave

[alfiedotwtf]

Code has been updated with your suggestions, but instead of M/P let's be more explicit i.e:

• Etc::GMT_Minus4
• Etc::GMT_Plus4

[alfiedotwtf]

Hey Dave,

Have you been able to have a look again?

Alfie

[autarch]

I was crazy busy with http;//www.tcvegfest.com/ until quite recently. I'll try to take a look some time this month.

[alfiedotwtf]

All good :) Thanks for the update.

[autarch]

I merged this manually. Note that I'm not going to enable --old by default so if you want these zones you'd have to rebuild the package from scratch.

[alfiedotwtf]

Hey Dave,

Awesome. Thanks for doing that.