houseabsolute / DateTime-TimeZone

Time zone object base class and factory
https://metacpan.org/release/DateTime-TimeZone/
Other
9 stars 25 forks source link

Issue with Olson 2006b database? #15

Open autarch opened 7 years ago

autarch commented 7 years ago

Migrated from rt.cpan.org #17832 (status was 'stalled')

Requestors:

From on 2006-02-23 16:21:51:

I used the parse_olson script (from DateTime-TimeZone-0.36) against the latest Olson DB files (2006b); in lib/DateTime/TimeZone/Asia/Jerusalem.pm, the last span produced came out as:

    [
64272092400,
1.#INF,
64272085200,
1.#INF,
7200,
0,
'IT'
    ]

By comparison to the previous file, I'm guessing it should have been:

    [
64272092400,
DateTime::TimeZone::INFINITY,
64272085200,
DateTime::TimeZone::INFINITY,
7200,
0,
'IT'
    ]

I found DateTime-TimeZone-0.42, and it's parse_olson script did the same thing.

Is this a problem with the Olson file, or does it point to something not set up correctly in my environment?

perl -v

This is perl, v5.8.4 built for MSWin32-x86-multi-thread (with 3 registered patches, see perl -V for more detail)

Copyright 1987-2004, Larry Wall

Binary build 810 provided by ActiveState Corp. http://www.ActiveState.com ActiveState is a division of Sophos. Built Jun 1 2004 11:52:21

uname -a CYGWIN_NT-5.1 gsskyles-mobl0 1.5.16(0.128/4/2) 2005-04-25 20:26 i686

autarch commented 7 years ago

From autarch@urth.org (@autarch) on 2006-02-23 16:24:42:

Actually, it's probably a Win32 issue. On some platforms Perl's handling of infinity seems kind of broken.

-dave

/=================================================== VegGuide.Org www.BookIRead.com Your guide to all that's veg. My book blog ===================================================/

autarch commented 7 years ago

From greg.s.skyles@intel.com on 2006-02-24 11:37:33:

Dave:

Thanks. A little post-processing with

sed 's/-1.#INF/DateTime::TimeZone::NEG_INFINITY/g; s/1.#INF/DateTime::TimeZone::INFINITY/g'

seems to have fixed things.

-Greg

"My grandfather once told me that there are two kinds of people: those who work and those who take the credit. He told me to try to be in the first group; there is less competition there." -Indira Gandhi (1917-1984)

autarch commented 7 years ago

From drolsky@cpan.org (@autarch) on 2014-08-30 20:29:44:

On Fri Feb 24 06:37:33 2006, greg.s.skyles@intel.com wrote:

Dave:

Thanks. A little post-processing with

sed 's/-1.#INF/DateTime::TimeZone::NEG_INFINITY/g; s/1.#INF/DateTime::TimeZone::INFINITY/g'

seems to have fixed things.

If you'd be willing to submit a patch that'd be great.

autarch commented 7 years ago

From drolsky@cpan.org (@autarch) on 2014-08-30 20:30:08:

On Sat Aug 30 16:29:44 2014, DROLSKY wrote:

On Fri Feb 24 06:37:33 2006, greg.s.skyles@intel.com wrote:

Dave:

Thanks. A little post-processing with

sed 's/-1.#INF/DateTime::TimeZone::NEG_INFINITY/g; s/1.#INF/DateTime::TimeZone::INFINITY/g'

seems to have fixed things.

If you'd be willing to submit a patch that'd be great.

I should note that the patch needs to be against the code that generates the zone files, not against the generated files themselves.