search

houseabsolute / DateTime-TimeZone

Time zone object base class and factory
https://metacpan.org/release/DateTime-TimeZone/
Other
9 stars 25 forks source link

Fix Etc/* offset timezones, they were backwards #48

Closed wolfsage closed 3 years ago

wolfsage commented 3 years ago

Per https://data.iana.org/time-zones/tzdb/etcetera Etc/GMT+4 actually means UTC-4, so we need to reverse the signs when we ingest these values.

For https://github.com/houseabsolute/DateTime-TimeZone/issues/47

codecov[bot] commented 3 years ago

Codecov Report

Merging #48 (4da1a0f) into master (c0c9e27) will not change coverage. The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #48   +/-   ##
=======================================
  Coverage   48.41%   48.41%           
=======================================
  Files          28       28           
  Lines         568      568           
  Branches       85       86    +1     
=======================================
  Hits          275      275           
  Misses        274      274           
  Partials       19       19
Impacted Files Coverage Δ
lib/DateTime/TimeZone.pm 25.61% <0.00%> (ø)
t/23etc_zones_offset.t 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c0c9e27...4da1a0f. Read the comment docs.

autarch commented 3 years ago

I merged this from the CLI. Thanks!

wolfsage commented 3 years ago

Thank you!