houseabsolute / DateTime-TimeZone

Time zone object base class and factory
https://metacpan.org/release/DateTime-TimeZone/
Other
9 stars 25 forks source link

Tweaks to allow reusing a previously-compiled database #54

Closed Hugmeir closed 1 year ago

Hugmeir commented 1 year ago

Ulterior motive: This allows generating DateTime::TimeZone using the global-tz fork of olsondb (https://github.com/JodaOrg/global-tz/tree/main).

This just adds a minor tweak to tools/update-from-latest-olson to allow skipping the compilation step if --no-compile is given as an option.

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (31dc61d) 48.41% compared to head (5c1cee0) 48.41%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #54 +/- ## ======================================= Coverage 48.41% 48.41% ======================================= Files 28 28 Lines 568 568 Branches 86 86 ======================================= Hits 275 275 Misses 274 274 Partials 19 19 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=houseabsolute). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=houseabsolute)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

autarch commented 1 year ago

Thanks for this! I tweaked the commit message and merged this.