search

houseabsolute / DateTime-TimeZone

Time zone object base class and factory
https://metacpan.org/release/DateTime-TimeZone/
Other
9 stars 25 forks source link

Observance: don't switch Etc/GMT[+-]N zone offsets #7

Closed brong closed 8 years ago

brong commented 8 years ago

It just makes things even MORE confusing. Let's stick with the Olson names and the Olson data exactly.

We had issues with the 14 zone, which of course only exists in one direction - and with clients being confused because our timezone names weren't Olson. That sucks. This fixes the issue by not trying to be clever about - just cloning Olson exactly for those domains as well.

autarch commented 8 years ago

Huh, I have no idea why it was implemented this way in the first place. There's no good reason to not match what Olson does, even if these zone names are bizarro.

autarch commented 8 years ago

Merged from the CLI. Thanks!

brong commented 8 years ago

Yeah, though this seems to be failing for reasons I haven't debugged yet. So I might have a new pr soon.

On Tue, Jun 7, 2016, at 15:47, Dave Rolsky wrote:

Huh, I have no idea why it was implemented this way in the first place. There's no good reason to not match what Olson does, even if these zone names are bizarro. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub[1], or mute the thread[2].

Bron Gondwana brong@fastmail.fm

Links:

  1. https://github.com/autarch/DateTime-TimeZone/pull/7#issuecomment-224184540
  2. https://github.com/notifications/unsubscribe/AABE7bCR0Ivv6hKiLaC65tioJuzD0qR6ks5qJQXigaJpZM4IvijS
autarch commented 8 years ago

I just merged it. It passed Travis just fine.