search

houseabsolute / Log-Dispatch

Dispatches messages to one or more outputs
https://metacpan.org/release/Log-Dispatch/
Other
12 stars 29 forks source link

Improve level validation and canonicalisation logic (updated) #42

Closed kyzn closed 7 years ago

kyzn commented 7 years ago

Hi Dave! Please find attached pull request, that is based on #34. You had requested a few changes there, I went ahead and replaced eval with Try::Tiny and wrote some tests.

Let me know if there's anything I should update. Thanks!

#cpan-prc

preaction commented 7 years ago

Thanks for the patch! Of the changes @autarch mentioned needing in #34, the only thing that isn't quite right is that the Changes entry doesn't mention Kerin Millar's name for the patch (and now your name, too, for writing tests and cleaning it up). Once that is done, then this should be able to be merged.

kyzn commented 7 years ago

Hi @preaction, thanks for your comment! I updated Changes per your comment. Let me know if it looks good.

autarch commented 7 years ago

Merged from the CLI. Thanks!

Closes #34.

ghost commented 7 years ago

@kyzn Thanks for picking this up and rendering it fit for inclusion.