search

houseabsolute / Log-Dispatch

Dispatches messages to one or more outputs
https://metacpan.org/release/Log-Dispatch/
Other
12 stars 29 forks source link

"use base" -> "use parent" #5

Closed dolmen closed 10 years ago

dolmen commented 10 years ago

From parent.pm:

"This module was forked from base to remove the cruft that had accumulated in it."

karenetheridge commented 10 years ago

When I said that parent was better, @ribasushi scolded me and told me to adjust my reality distortion field: http://blogs.perl.org/users/brendan_byrd/2013/03/the-four-major-problems-with-cpan.html#comment-395703

I think we might be better off trying to reunify base.pm and parent.pm - removing any true performance issues that remain, and making one be an alias for the other. OR, at least correcting the documentation!

autarch commented 10 years ago

As was discussed here and in RT, there doesn't appear to be much point in doing this.

dolmen commented 10 years ago

base.pm had cruft in it, and still has. For example it uses an eval-string to load the class which means that use base $BASE can be exploited if $BASE comes from untrusted input. And use base $BASE is really used in the wild.

@karenetheridge base.pm and parent.pm do things in a different way in some corner cases, so it's not possible to just replace one with the other.

None of this is relevant to the usage of base.pm in Log::Dispatch.

dolmen commented 10 years ago

My statement about base.pm and eval string only applies to the latest base.pm available from CPAN (2.18). base.pm bundled with recent versions of perl is fixed.

karenetheridge commented 10 years ago

On Thu, Sep 04, 2014 at 02:30:28PM -0700, Olivier Mengué wrote:

My statement about base.pm and eval string only applies to the latest base.pm available from CPAN. base.pm bundled with recent versions of perl is fixed.

That's quite a code drift. Is there a p5p ticket open to get that released to the cpan?

dolmen commented 10 years ago

Is there a p5p ticket open to get that released to the cpan?

I did RT#98621 (in the rt.cpan.org queue for base) a few hours ago. I expect that @rgs will see it.