houseabsolute / Log-Dispatch

Dispatches messages to one or more outputs
https://metacpan.org/release/Log-Dispatch/
Other
12 stars 29 forks source link

Add utf8 parameter for Log::Dispatch::Screen #8

Closed basiliscos closed 9 years ago

basiliscos commented 9 years ago

Hi,

The parameter is very similar one as in Log::Log4perl::Appender::Screen :)

autarch commented 9 years ago

I like the idea, but we can't just blindly binmode global filhandles like that. I think the right way to do this is to save and restore the layers (via PerlIO::get_layers()) in the log_message() sub.

autarch commented 9 years ago

This turned out to be a bit more complicated than I realized, but it will be in the next release.