search

houseabsolute / Time-Local

Efficiently compute time from local and GMT time
https://metacpan.org/release/Time-Local/
Other
4 stars 11 forks source link

Avoid redundant check #4

Closed niczero closed 7 years ago

niczero commented 7 years ago

No need to check OS twice.

preaction commented 7 years ago

Thanks! This looks good to me, but it seems the tests are failing because the code has not been re-tidied. Please follow these instructions to run tidyall and then amend your commit.

niczero commented 7 years ago

After an hour and a half I have installed (59 + 18 + 1) distributions and ran 'tidyall -a' and then killed the process and hacked tidyall.ini to exclude my dependencies tree and then re-ran it and got:

Time-Local$ time dep/bin/tidyall -a
[checked] lib/Time/Local.pm
No such file or directory at dep/lib/Code/TidyAll/Plugin/PerlCritic.pm line 21.
[checked] t/Local.t
No such file or directory at dep/lib/Code/TidyAll/Plugin/PerlCritic.pm line 21.

real    0m3.970s
niczero commented 7 years ago

Contributing shouldn't be this difficult, so after 2 hrs on a 5-min PR, I'm walking away. Sad.