Open mateocabanal opened 9 months ago
Hi Mateo,
Thanks for this. Is there any chance you'd be up for adding a test for this? I'm not sure exactly how you might do this. We'd need some sort of argument that breaks in this position and is necessary for the project in test-project
to compile or test properly.
Yes I'd love to help. I'll try and make the tests pass. I should've checked before publishing a PR
Yes I'd love to help. I'll try and make the tests pass. I should've checked before publishing a PR
The test failures mostly don't come from your change. I fixed the issues so you should rebase off the v0
branch. The linting failure is from your change, however.
All tests now pass! The lint failed due to an extra whitespice I accidentally added. Should be good to go now!
Hi @mateocabanal,
Thanks for fixing the linting issue. But what I was saying earlier is that this also needs some actual tests:
Is there any chance you'd be up for adding a test for this? I'm not sure exactly how you might do this. We'd need some sort of argument that breaks in this position and is necessary for the project in
test-project
to compile or test properly.
I have a library that requires tests to run sequentially. When using this action, I'd add
-- --test-threads=1
to theargs
section. Sadly, this didn't work. After some digging, I noticed the--target
argument is appended to the user args. Instead, I have prepended the--target
argument.